Allow setting a custom Authenticator #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Lourie <djay.il@gmail.com>
|
@Zariel, @magaldima something along these lines? If this looks the right direction, I'll add the failure when can't create the |
|
I'm specifically worried now that the input |
Zariel
suggested changes
Nov 16, 2018
cluster.go
Outdated
| Consistency Consistency // default consistency level (default: Quorum) | ||
| Compressor Compressor // compression algorithm (default: nil) | ||
| Authenticator Authenticator // authenticator (default: nil) | ||
| AuthProvider func(h string) (Authenticator, error) // an authenticator factory. Can be used to create alternative authenticators (default: nil) |
There was a problem hiding this comment.
I think this should take a HostInfo
conn.go
Outdated
| if cfg.AuthProvider != nil { | ||
| c.auth, err = cfg.AuthProvider(host.ConnectAddress().String()) | ||
| if err != nil { | ||
| // Fail? |
Signed-off-by: Alex Lourie <djay.il@gmail.com>
Zariel
approved these changes
Nov 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1238
Fixes #1109
Signed-off-by: Alex Lourie djay.il@gmail.com