Add temp dir property for native library#4533
Conversation
dlg99
left a comment
There was a problem hiding this comment.
Idea lgtm but please refactor this into a reusable utility method so the code is not repeated 3 times.
f1ed167 to
a7d31a8
Compare
|
@dlg99 I'm not sure why What do you think? |
|
I decided to remove guava from native-library-common. @dlg99 PTAL |
|
LGTM but please check what's up with the CI / why PR validation is failing |
2a402a6 to
d43b749
Compare
|
A failed job runs on Conversely, succeeded jobs run on
It's probably due to the actions/runner-images#10636. I tested it in below.
I am now considering downgrading the image version to |
|
Addressed #4533 (comment) issue in #4536. |
d43b749 to
aa45676
Compare
aa45676 to
af44b07
Compare
|
rerun failure checks |
|
@dlg99 Note: |
|
@dlg99 |
af44b07 to
5016bf4
Compare
|
5016bf4 to
4565568
Compare
|
rebased to current master (0748423) |
Motivation
If the default temporary directory is not available, native libraries cannot be loaded.
For this situation, other projects have the ability to set custom working directory.
I would like to add such feature to BookKeeper.
examples:
Changes