Skip to content

Remove redundant array creation code in InferableFunction and SimpleFunction #8192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaltay merged 2 commits into from
Apr 9, 2019
Merged

Remove redundant array creation code in InferableFunction and SimpleFunction #8192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d7056c
Remove redundent array creation code when calling vararg functions in…
robinyqiu Apr 1, 2019
44044d8
Remove redundant array creation code in SimpleFunction as well
robinyqiu Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/InferableFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ protected InferableFunction() {
// reflection.
try {
Method methodThatMustBeOverridden =
InferableFunction.class.getDeclaredMethod("apply", new Class[] {Object.class});
Method methodOnSubclass = getClass().getMethod("apply", new Class[] {Object.class});
InferableFunction.class.getDeclaredMethod("apply", Object.class);
Method methodOnSubclass = getClass().getMethod("apply", Object.class);

if (methodOnSubclass.equals(methodThatMustBeOverridden)) {
throw new IllegalStateException(
Expand Down
4 changes: 2 additions & 2 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SimpleFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ protected SimpleFunction() {
// reflection.
try {
Method methodThatMustBeOverridden =
SimpleFunction.class.getDeclaredMethod("apply", new Class[] {Object.class});
Method methodOnSubclass = getClass().getMethod("apply", new Class[] {Object.class});
SimpleFunction.class.getDeclaredMethod("apply", Object.class);
Method methodOnSubclass = getClass().getMethod("apply", Object.class);

if (methodOnSubclass.equals(methodThatMustBeOverridden)) {
throw new IllegalStateException(
Expand Down