Remove redundant array creation code in InferableFunction and SimpleFunction #8192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinyqiu
changed the title
Contributor
Author
|
Run Java PreCommit |
kennknowles
approved these changes
Apr 2, 2019
Member
kennknowles
left a comment
kennknowles
left a comment
There was a problem hiding this comment.
Seems we have a very long Java precommit queue. I will merge when green.
Contributor
|
Run Java PreCommit |
4 similar comments
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Ping. PreCommit finally passed! |
Contributor
Author
|
cc: @aaltay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when calling function that accepts varargs
r: @kennknowles
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.