Add the simple RC workflow to validate Go SDK with wordcount #34476
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| - name: Set up environment | ||
| uses: ./.github/actions/setup-environment-action | ||
| with: | ||
| go-version: default, otherwise remove if default is 1.21 |
There was a problem hiding this comment.
Should this be a comment? Seems like this will definitely error
| working-directory: ./sdks/go/examples/wordcount | ||
| run: | | ||
| echo "--- PrismRunner WordCount Output ---" | ||
| cat output_prism.txt* # Output might be sharded |
There was a problem hiding this comment.
Is the idea we will still ask folks to take a look at this output as part of the release instructions?
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.cache/go-build |
There was a problem hiding this comment.
I don't think we've built anything, so I don't think this will do anything. In general, I don't see any real value in this caching step; the go builds are quite fast anyways.
| runs-on: self-hosted | ||
| outputs: | ||
| rc_tag: ${{ github.event.inputs.rc_tag }} | ||
| container_tag: ${{ github.event.inputs.container_tag }} |
There was a problem hiding this comment.
We don't need this as an output - instead of referencing outputs in future jobs, you can just directly reference github.event.inputs.container_tag - this just adds a layer of indirection
|
Thanks for the comments. The main goal for this PR is to create the stub for me to continue refining the workflow once this is merged first. I will address your comments later. Sounds good? |
I'm fine with that as long as they get addressed. I do think they will make life easier for you though, so I'd recommend taking them :) |
Addresses #34457
Need merge first and then do the real tests.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.