[BLAZE-1137] Extracting celeborn/uniffle/paimon code to seperated modules#1136
Merged
richox merged 6 commits intoapache:masterfrom Aug 14, 2025
Merged
[BLAZE-1137] Extracting celeborn/uniffle/paimon code to seperated modules#1136richox merged 6 commits intoapache:masterfrom
richox merged 6 commits intoapache:masterfrom
Conversation
turboFei
force-pushed
the
third_party
branch
5 times, most recently
from
3732896 to
d2ff92b
Compare
turboFei
changed the title
turboFei
force-pushed
the
third_party
branch
4 times, most recently
from
e9a438c to
cd520ad
Compare
richox
reviewed
Aug 11, 2025
Contributor
|
i think this pr is no longer needed after modules separated: #1124 |
Member
Author
Do you mean we only support celeborn-0.6 officially? I am fine ether support celeborn-0.6 officially only. or use different source path for celeborn-0.5 and celeborn 0.6. |
richox
approved these changes
Aug 12, 2025
Member
Author
|
unrelated GA failure, will try GA later |
Member
Author
|
rebased the code |
cxzl25
reviewed
Aug 15, 2025
| </profile> | ||
|
|
||
| <profile> | ||
| <id>celeborn-0.5</id> |
Contributor
There was a problem hiding this comment.
It seems that using this profile will fail to compile. Do we have any plans to support it? Or only the latest version is supported
BlazeCelebornShuffleReader.scala:65: one more argument than can be applied to constructor CelebornShuffleReader: (handle: org.apache.spark.shuffle.celeborn.CelebornShuffleHandle[K, _, C], startPartition: Int, endPartition: Int, startMapIndex: Int, endMapIndex: Int, context: org.apache.spark.TaskContext, conf: org.apache.celeborn.common.CelebornConf, metrics: org.apache.spark.shuffle.ShuffleReadMetricsReporter, shuffleIdTracker: org.apache.spark.shuffle.celeborn.ExecutorShuffleIdTracker)org.apache.spark.shuffle.celeborn.CelebornShuffleReader[K,C]
Member
Author
There was a problem hiding this comment.
fixed in this pr, also added GA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1137
Rationale for this change
Address comment: #1124 (comment)
What changes are included in this PR?
Are there any user-facing changes?
No.