ARROW-1875: [Java] Write 64-bit ints as strings in integration test JSON files #5002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It is surprising that this passes, I will need to check it out and run it locally to make sure something funny isn't happening. But then i think it can be merged. |
praveenbingo
reviewed
Aug 9, 2019
java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileReader.java
Show resolved
Hide resolved
Contributor
Author
Hi Micah, Anything found？ |
praveenbingo
pushed a commit
that referenced
this pull request
Aug 13, 2019
…al overflow Related to [ARROW-6218](https://issues.apache.org/jira/browse/ARROW-6218). As per discussion #5002 For UINT type, when write/read json data in integration test, it extend data type(i.e. Long->BigInteger, Int->Long) to avoid potential overflow. Like UINT8 the write side and read side code like this: >case UINT8: generator.writeNumber(UInt8Vector.getNoOverflow(buffer, index)); break; >BigInteger value = parser.getBigIntegerValue(); buf.writeLong(value.longValue()); Should add a test to avoid potential overflow in the data transfer process. Closes #5072 from tianchen92/ARROW-6218 and squashes the following commits: 2bdbe7e <tianchen> use MIN_VALUE and MAX_VALUE 1430979 <tianchen> ARROW-6218: Add UINT type test in integration to avoid potential overflow Authored-by: tianchen <niki.lj@alibaba-inc.com> Signed-off-by: Praveen <praveen@dremio.com>
Contributor
|
OK, the reason why this doesn't break other languages is the integration tests don't seem to actually use the write path (arrow->json), and the read path (json->arrow) is robust to either strings or numbers. So I think this can be merged. And we can have other languages make similar changes and then change the python script. CC @wesm |
Contributor
|
+1 thank you. |
This was referenced Sep 10, 2019
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…al overflow Related to [ARROW-6218](https://issues.apache.org/jira/browse/ARROW-6218). As per discussion apache#5002 For UINT type, when write/read json data in integration test, it extend data type(i.e. Long->BigInteger, Int->Long) to avoid potential overflow. Like UINT8 the write side and read side code like this: >case UINT8: generator.writeNumber(UInt8Vector.getNoOverflow(buffer, index)); break; >BigInteger value = parser.getBigIntegerValue(); buf.writeLong(value.longValue()); Should add a test to avoid potential overflow in the data transfer process. Closes apache#5072 from tianchen92/ARROW-6218 and squashes the following commits: 2bdbe7e <tianchen> use MIN_VALUE and MAX_VALUE 1430979 <tianchen> ARROW-6218: Add UINT type test in integration to avoid potential overflow Authored-by: tianchen <niki.lj@alibaba-inc.com> Signed-off-by: Praveen <praveen@dremio.com>
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…SON files Related to [ARROW-1875](https://issues.apache.org/jira/browse/ARROW-1875). This is Java side implementation. Closes apache#5002 from tianchen92/ARROW-1875 and squashes the following commits: 20cc581 <tianchen> ARROW-1875: Write 64-bit ints as strings in integration test JSON files Authored-by: tianchen <niki.lj@alibaba-inc.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ARROW-1875.
This is Java side implementation.