[Java] Write 64-bit ints as strings in integration test JSON files

[asfimport]

Javascript can't handle 64-bit integers natively, so writing them as strings in the JSON would make implementing the integration tests a lot simpler.

Reporter: Brian Hulette / @TheNeuralBit
Assignee: Ji Liu / @tianchen92

Subtasks:

• [C++] Write 64-bit integers as strings in JSON integration test files

Related issues:

• [Developer] Tracking issue: use strings for 64-bit int64 and uint64 in integration test JSON format (is a child of)

PRs and other links:

• GitHub Pull Request #5002

_{Note: This issue was originally created as ARROW-1875. Please see the migration documentation for further details.}

[asfimport]

Wes McKinney / @wesm:
Moving to 0.10.0. Should try to do this in the course of completing the JS integration tests (reading and writing)

[asfimport]

Wes McKinney / @wesm:
[~paul.e.taylor] @TheNeuralBit how much work is this on the JS side? The C++ and Java side should be relatively straightforward

[asfimport]

Brian Hulette / @TheNeuralBit:
This should be pretty straightforward on the Javascript side too. It's not a major priority since we were able to workaround the issue using json-bignum, but it would be nice to drop that dependency.

[asfimport]

Wes McKinney / @wesm:
OK. Let's take care of it in the 0.11 release cycle

[asfimport]

Wes McKinney / @wesm:
Need someone to commit to provide timely help on the Java side before we can do this. I'm ready to do the work in C++ whenever it is required

[asfimport]

Wes McKinney / @wesm:
@siddharthteotia could you or anyone help with this on the Java side? I don't think this should be a huge project

[asfimport]

Wes McKinney / @wesm:
@pravindra any chance someone on your end might be able to look at this? We'd also have to make changes in C++, so we probably would want to create a branch where we can collaborate on this change

[asfimport]

Wes McKinney / @wesm:
[~emkornfield@gmail.com] [~paul.e.taylor] any chance the three of us could collude to make this change? I can help with the C++ work if there is Java and JS work to happen at the same time

[asfimport]

Micah Kornfield / @emkornfield:
@wesm I should be able to fit this in for Java. What timeframe were you thinking?

[asfimport]

Wes McKinney / @wesm:
Anytime, doesn't need to be for 0.14

[asfimport]

Ji Liu / @tianchen92:
[~emkornfield@gmail.com] Not familiar with integration. Does this mean replace JsonFileWriter#generator.writeNumber with writeString for BigInt？

[asfimport]

Micah Kornfield / @emkornfield:
I would need to double check the code, but yes I believe it is in JsonFileWriter.  The idea is that javascript can better parse the longs as JSON strings then as JSON numbers.

[asfimport]

Micah Kornfield / @emkornfield:
We would also need to update the read path, and coordinate with contributors from the other implementations.

[asfimport]

Ji Liu / @tianchen92:
[~emkornfield@gmail.com] Thanks for clarify, what about I creating a new branch and invite people who are interested in other implementations to coordinate in Github (I can help with java side) ), once all implementations works done, we could get it merged.

[asfimport]

Micah Kornfield / @emkornfield:
I created: https://github.com/apache/arrow/tree/integration_ints_as_strings