GH-48362: [GLib][Ruby] Add FixedSizeListArray #48369
Merged
+633
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kou
approved these changes
Dec 5, 2025
| def setup | ||
| require_gi_bindings(3, 1, 9) | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
Could you define a helper method that gets the i-th value to shorten test code?
Suggested change
| def get_value(array, i) | |
| value = array.get_value(i) | |
| value.length.times.collect do |j| | |
| value.get_value(j) | |
| end | |
| end | |
Comment on lines
51
to
54
| assert_equal([1, 2], array.get_value(0).length.times.collect {|i| | ||
| array.get_value(0).get_value(i)}) | ||
| assert_equal([3, 4], array.get_value(1).length.times.collect {|i| | ||
| array.get_value(1).get_value(i)}) |
Member
There was a problem hiding this comment.
Suggested change
| assert_equal([1, 2], array.get_value(0).length.times.collect {|i| | |
| array.get_value(0).get_value(i)}) | |
| assert_equal([3, 4], array.get_value(1).length.times.collect {|i| | |
| array.get_value(1).get_value(i)}) | |
| assert_equal([1, 2], get_value(array, 0)) | |
| assert_equal([3, 4], get_value(array, 1)) |
Comment on lines
78
to
79
| assert_equal([1, 2], array.get_value(0).length.times.collect {|i| | ||
| array.get_value(0).get_value(i)}) |
Member
There was a problem hiding this comment.
Suggested change
| assert_equal([1, 2], array.get_value(0).length.times.collect {|i| | |
| array.get_value(0).get_value(i)}) | |
| assert_equal([1, 2], get_value(array, 0)) |
| assert_equal(3, array.length) | ||
| assert_equal([1, 2], array.get_value(0).length.times.collect {|i| | ||
| array.get_value(0).get_value(i)}) | ||
| assert_equal(true, array.null?(1)) |
Member
There was a problem hiding this comment.
Could you use assert with block for predicate? It shows more useful information on failure.
Suggested change
| assert_equal(true, array.null?(1)) | |
| assert do | |
| array.null?(1) | |
| end |
Comment on lines
81
to
82
| assert_equal([5, 6], array.get_value(2).length.times.collect {|i| | ||
| array.get_value(2).get_value(i)}) |
Member
There was a problem hiding this comment.
Suggested change
| assert_equal([5, 6], array.get_value(2).length.times.collect {|i| | |
| array.get_value(2).get_value(i)}) | |
| assert_equal([5, 6], get_value(array, 2)) |
github-actions
bot
added
awaiting merge
stenlarsson
force-pushed
the
glib-fixed-size-list-array
branch
from
8f7ca5f to
60aff82
Compare
Contributor
Author
|
Thanks for the review @kou. Updated according to your suggestions. |
This was referenced Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
FixedSizeListArrayclass is not available in GLib/Ruby, and it can be the result of e.g. theextract_regex_spanandlist_slicecompute functions.What changes are included in this PR?
This adds the
GArrowFixedSizeListArrayandGArrowFixedSizeListArrayBuilderto GLib.Are these changes tested?
Yes, with Ruby unit tests.
Are there any user-facing changes?
Yes, new classes.