Skip to content

Commit 60aff82

Browse files
committed
Simplify test
1 parent 70351a0 commit 60aff82

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

c_glib/test/test-fixed-size-list-array-builder.rb

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ def setup
2323
require_gi_bindings(3, 1, 9)
2424
end
2525

26+
def get_value(array, i)
27+
value = array.get_value(i)
28+
value.length.times.collect do |j|
29+
value.get_value(j)
30+
end
31+
end
32+
2633
def test_new
2734
field = Arrow::Field.new("value", Arrow::Int8DataType.new)
2835
data_type = Arrow::FixedSizeListDataType.new(field, 2)
@@ -48,10 +55,8 @@ def test_append_value
4855

4956
array = builder.finish
5057
assert_equal(2, array.length)
51-
assert_equal([1, 2], array.get_value(0).length.times.collect {|i|
52-
array.get_value(0).get_value(i)})
53-
assert_equal([3, 4], array.get_value(1).length.times.collect {|i|
54-
array.get_value(1).get_value(i)})
58+
assert_equal([1, 2], get_value(array, 0))
59+
assert_equal([3, 4], get_value(array, 1))
5560
end
5661

5762
def test_append_null
@@ -75,11 +80,11 @@ def test_append_null
7580

7681
array = builder.finish
7782
assert_equal(3, array.length)
78-
assert_equal([1, 2], array.get_value(0).length.times.collect {|i|
79-
array.get_value(0).get_value(i)})
80-
assert_equal(true, array.null?(1))
81-
assert_equal([5, 6], array.get_value(2).length.times.collect {|i|
82-
array.get_value(2).get_value(i)})
83+
assert_equal([1, 2], get_value(array, 0))
84+
assert do
85+
array.null?(1)
86+
end
87+
assert_equal([5, 6], get_value(array, 2))
8388
end
8489

8590
def test_value_builder

0 commit comments

Comments
 (0)