-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47978: [C++][Parquet][CI] Add more compression codecs to fuzzing seed corpus #47979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@github-actions crossbow submit fuzz |
|
Revision: efa842a Submitted crossbow builds: ursacomputing/crossbow @ actions-9baaa59a9e
|
|
@github-actions crossbow submit fuzz |
|
Revision: 4bbdd6a Submitted crossbow builds: ursacomputing/crossbow @ actions-001f65930b
|
|
Nice! What about the other compressions (LZO, BZ2, LZ4_*)? |
|
These are all the compression codecs that Parquet C++ supports. BZ2 is not in the Parquet format, and LZO is closed source. |
Fine with me, was just wondering since they are defined: arrow/cpp/src/arrow/util/type_fwd.h Lines 46 to 60 in f8a0902
|
EnricoMi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Well, some of them are supported by other parts of Arrow. For example you could read a BZ2-compressed CSV file. |
Rationale for this change
Are these changes tested?
Not specifically by CI, but hopefully they will make fuzzing more efficient.
Are there any user-facing changes?
No.