-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47572: [C++][Parquet] Generalize bpacking and possible speedup #47573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AntoinePrv
wants to merge
61
commits into
apache:main
Choose a base branch
from
AntoinePrv:bit-packing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60,458
−15,029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
de89288
to
60f9155
Compare
fd5ff83
to
d96f782
Compare
This reverts commit 2aeb76ea7dc3620dc678b55e3f60f5842ba6ce91.
This reverts commit 8a0c4ff3642e1d1e965d6c4a09f2edff0c341b7a.
e39a073
to
4512ec3
Compare
4512ec3
to
d57a53b
Compare
The results for this are not good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Refactor the unpack function code generator and dispatcher to accommodate more use cases:
uint16_t
anduint64_t
new sizesWhat changes are included in this PR?
The diff are hard to look at but the important files to look at are:
uint16
on Avx512 for which the algorithms assumptions break);unpack29_32
>Unpacker<uint32_t, 29>::unpack
bpacking_internal.h
are also template specializationunpack32
->unpack<uint32_t>
switch
statements and for loops used to dispatch the bit width to its appropriate implementation are now all generic with aconstexpr
generated jump table. The logic is inbpacking_dispatch_internal.h
From a performance perspective:
uint16_t
unpack<uint64_t>
has an SIMD implementation that should benefitDeltaBitPackDecoder
unpack<uint16_t>
should benefit the level decodersget_unpack_fn
for the building block).Are these changes tested?
Very much.
Are there any user-facing changes?