Remove unpack on SSE4.2

Author: AntoinePrv

cpp/src/arrow/util/bpacking_benchmark.cc

@@ -136,15 +136,6 @@ BENCHMARK_CAPTURE(BM_UnpackUint32, ScalarUnaligned, false, &unpack_scalar<uint32
 BENCHMARK_CAPTURE(BM_UnpackUint64, ScalarUnaligned, false, &unpack_scalar<uint64_t>)
     ->ArgsProduct(kBitWidthsNumValues64);
 
-#if defined(ARROW_HAVE_SSE4_2)
-BENCHMARK_CAPTURE(BM_UnpackUint16, Sse42Unaligned, false, &unpack_sse4_2<uint16_t>)
-    ->ArgsProduct(kBitWidthsNumValues16);
-BENCHMARK_CAPTURE(BM_UnpackUint32, Sse42Unaligned, false, &unpack_sse4_2<uint32_t>)
-    ->ArgsProduct(kBitWidthsNumValues32);
-BENCHMARK_CAPTURE(BM_UnpackUint64, Sse42Unaligned, false, &unpack_sse4_2<uint64_t>)
-    ->ArgsProduct(kBitWidthsNumValues64);
-#endif
-
 #if defined(ARROW_HAVE_RUNTIME_AVX2)
 BENCHMARK_CAPTURE(BM_UnpackUint16, Avx2Unaligned, false, &unpack_avx2<uint16_t>,
                   !CpuInfo::GetInstance()->IsSupported(CpuInfo::AVX2),

cpp/src/arrow/util/bpacking_simd_internal.h

@@ -42,25 +42,6 @@ extern template ARROW_TEMPLATE_EXPORT int unpack_neon<uint64_t>(const uint8_t*,
 
 #endif
 
-#if defined(ARROW_HAVE_SSE4_2)
-
-template <typename Uint>
-ARROW_EXPORT int unpack_sse4_2(const uint8_t* in, Uint* out, int batch_size,
-                               int num_bits);
-
-extern template ARROW_TEMPLATE_EXPORT int unpack_sse4_2<uint8_t>(const uint8_t*, uint8_t*,
-                                                                 int, int);
-
-extern template ARROW_TEMPLATE_EXPORT int unpack_sse4_2<uint16_t>(const uint8_t*,
-                                                                  uint16_t*, int, int);
-
-extern template ARROW_TEMPLATE_EXPORT int unpack_sse4_2<uint32_t>(const uint8_t*,
-                                                                  uint32_t*, int, int);
-
-extern template ARROW_TEMPLATE_EXPORT int unpack_sse4_2<uint64_t>(const uint8_t*,
-                                                                  uint64_t*, int, int);
-#endif
-
 #if defined(ARROW_HAVE_AVX2) || defined(ARROW_HAVE_RUNTIME_AVX2)
 
 template <typename Uint>

cpp/src/arrow/util/bpacking_simd_min.cc

@@ -35,18 +35,4 @@ template int unpack_neon<uint64_t>(const uint8_t*, uint64_t*, int, int);
 
 #endif
 
-#if defined(ARROW_HAVE_SSE4_2)
-
-template <typename Uint>
-int unpack_sse4_2(const uint8_t* in, Uint* out, int batch_size, int num_bits) {
-  return unpack_jump<Simd128UnpackerForWidth>(in, out, batch_size, num_bits);
-}
-
-template int unpack_sse4_2<uint8_t>(const uint8_t*, uint8_t*, int, int);
-template int unpack_sse4_2<uint16_t>(const uint8_t*, uint16_t*, int, int);
-template int unpack_sse4_2<uint32_t>(const uint8_t*, uint32_t*, int, int);
-template int unpack_sse4_2<uint64_t>(const uint8_t*, uint64_t*, int, int);
-
-#endif
-
 }  // namespace arrow::internal

cpp/src/arrow/util/bpacking_test.cc

@@ -223,13 +223,6 @@ TEST_P(TestUnpack, Unpack16Scalar) { this->TestAll(&unpack_scalar<uint16_t>); }
 TEST_P(TestUnpack, Unpack32Scalar) { this->TestAll(&unpack_scalar<uint32_t>); }
 TEST_P(TestUnpack, Unpack64Scalar) { this->TestAll(&unpack_scalar<uint64_t>); }
 
-#if defined(ARROW_HAVE_SSE4_2)
-TEST_P(TestUnpack, Unpack8Sse42) { this->TestAll(&unpack_sse4_2<uint8_t>); }
-TEST_P(TestUnpack, Unpack16Sse42) { this->TestAll(&unpack_sse4_2<uint16_t>); }
-TEST_P(TestUnpack, Unpack32Sse42) { this->TestAll(&unpack_sse4_2<uint32_t>); }
-TEST_P(TestUnpack, Unpack64Sse42) { this->TestAll(&unpack_sse4_2<uint64_t>); }
-#endif
-
 #if defined(ARROW_HAVE_RUNTIME_AVX2)
 TEST_P(TestUnpack, Unpack8Avx2) {
   if (!CpuInfo::GetInstance()->IsSupported(CpuInfo::AVX2)) {