Skip to content

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Aug 7, 2025

Rationale for this change

Nightlies failing to build with openSSL < 3.0

What changes are included in this PR?

Ditch those builds while we figure out if we need to drop support or not in the more complex #47280

Are these changes tested?

No but I'll check if things build

Are there any user-facing changes?

Yup, no nightly binaries if you've got openSSL < 3 but they've not been built since mid-July anyway, so not really

@github-actions
Copy link

github-actions bot commented Aug 7, 2025

⚠️ GitHub issue #47277 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Aug 7, 2025
@thisisnic
Copy link
Member Author

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

github-actions bot commented Aug 7, 2025

Revision: 81960aa08d5fcd32f72f4cdbfbd85ff73bd30435

Submitted crossbow builds: ursacomputing/crossbow @ actions-719c727a9a

Task Status
r-binary-packages GitHub Actions

@kou kou changed the title GH-47277: [R] r-binary-packages nightly failures GH-47277: [R] Drop support for OpenSSL 1 binaries Aug 8, 2025
@kou
Copy link
Member

kou commented Aug 8, 2025

It seems that we need to update more. For example:

{% for openssl_version in ["1.0", "1.1", "3.0"] %}

{% for openssl_version in ["1.1", "3.0"] %}

If we have documents about OpenSSL 1 binaries, we need to update them too.

@thisisnic
Copy link
Member Author

Cheers @kou for pointing me towards the macros! I'm keeping the scope of this PR fairly minimal just to get the nightlies building again ASAP, and following up on the rest of the removal in #47280.

@thisisnic
Copy link
Member Author

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

github-actions bot commented Aug 8, 2025

Revision: 3f1cf1549dc010f5746752aebeb5f5e2aa4dd2e7

Submitted crossbow builds: ursacomputing/crossbow @ actions-cfd6bc4b6a

Task Status
r-binary-packages GitHub Actions

@thisisnic thisisnic changed the title GH-47277: [R] Drop support for OpenSSL 1 binaries GH-47277: [R] Disable building OpenSSL 1.X binaries Aug 8, 2025
@thisisnic
Copy link
Member Author

This is looking good now - correct jobs building above, and the failure is only because of R 4.0 which has been addressed in #47285

@kou
Copy link
Member

kou commented Aug 8, 2025

Could you rebase on main?

@thisisnic thisisnic force-pushed the GH-47277-get-nightlies-building-again branch from 3f1cf15 to b2d769a Compare August 8, 2025 08:52
@thisisnic
Copy link
Member Author

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

github-actions bot commented Aug 8, 2025

Revision: b2d769a

Submitted crossbow builds: ursacomputing/crossbow @ actions-ddb3a18ee4

Task Status
r-binary-packages GitHub Actions

@thisisnic
Copy link
Member Author

This fix isn't actually needed; superseded by #47299

@thisisnic thisisnic closed this Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting committer review Awaiting committer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants