GH-45449: [R][CI] Remove OpenSSL 1.x builds #47280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: R
awaiting committer review
Comment on lines
273
to
275
| #if OPENSSL_VERSION_NUMBER >= 0x30000000L | ||
| #error Using OpenSSL version 3 | ||
| #endif |
Member
There was a problem hiding this comment.
I think you need to remove this now, you either have openssl 3.0 or not
Suggested change
| #if OPENSSL_VERSION_NUMBER >= 0x30000000L | |
| #error Using OpenSSL version 3 | |
| #endif |
| # openssl is < 3.0 | ||
| lg("Found libcurl and OpenSSL >= 1.1") | ||
| return("openssl-1.1") | ||
| # There was no error in compiling: so we found libcurl and OpenSSL >= 3.0, |
Member
There was a problem hiding this comment.
See comment above, if you don't remove that second check, the script will error on openssl >= 3.0 so this won't be true.
| } | ||
| lg("Found libcurl and OpenSSL < 1.1") | ||
| return("openssl-1.0") | ||
| } else if (any(grepl("Using OpenSSL version 3", errs))) { |
Member
There was a problem hiding this comment.
And I think you can remove this last else if
Member
Author
|
Thanks for the review @nealrichardson! Just FYI, I'm now no longer entirely convinced that the source of the problem with the binaries was definitely OpenSSL 1.X compatibility and I'm going to look into that a bit more. |
Member
Author
|
This fix isn't actually needed; superseded by #47299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?