Skip to content

GH-45155: [Python][CI] Fix path for scientific nightly windows wheel upload #45222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 13, 2025
Merged

GH-45155: [Python][CI] Fix path for scientific nightly windows wheel upload #45222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
133a0e8
fix path
assignUser Jan 10, 2025
e670207
make upload fail when missing wheels
assignUser Jan 10, 2025
bf894ff
remove main gate for testing
assignUser Jan 10, 2025
46a2b0c
use find to check glob
assignUser Jan 10, 2025
7f3901b
actually fix the path
assignUser Jan 11, 2025
a4047f4
Revert "use find to check glob"
assignUser Jan 11, 2025
3eb9b7f
Revert "remove main gate for testing"
assignUser Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dev/tasks/macros.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,12 @@ env:
- name: Upload wheel to Anaconda scientific-python
shell: bash
run: |
# check if completion actually expands to wheel files
# to prevent empty dirs from failing silently
if ! compgen -G "{{ pattern }}" > /dev/null; then
echo "No wheel files found!"
exit 1
Comment on lines +192 to +193
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use 2-space indent like others?

Suggested change
echo "No wheel files found!"
exit 1
echo "No wheel files found!"
exit 1

fi
python3 -m pip install git+https://github.com/Anaconda-Platform/anaconda-client.git@1.12.3
anaconda -t ${CROSSBOW_SCIENTIFIC_PYTHON_UPLOAD_TOKEN} upload --force -u scientific-python-nightly-wheels --label main {{ pattern }}
env:
Expand Down
2 changes: 1 addition & 1 deletion dev/tasks/python-wheels/github.windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:

{{ macros.github_upload_releases("arrow/python/repaired_wheels/*.whl")|indent }}
{{ macros.github_upload_gemfury("arrow/python/repaired_wheels/*.whl")|indent }}
{{ macros.github_upload_wheel_scientific_python("arrow/repaired_wheels/repaired_wheels/*.whl")|indent }}
{{ macros.github_upload_wheel_scientific_python("arrow/python/repaired_wheels/*.whl")|indent }}

{% if arrow.is_default_branch() %}
- name: Push Docker image
Expand Down
Loading