Skip to content

GH-45155: [Python][CI] Fix path for scientific nightly windows wheel upload #45222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 13, 2025
Merged

GH-45155: [Python][CI] Fix path for scientific nightly windows wheel upload #45222

merged 7 commits into from
Jan 13, 2025

Conversation

@assignUser
Copy link
Member

@assignUser assignUser commented Jan 10, 2025 •
edited by github-actions bot
Loading

Rationale for this change

The upload wasn't failing with the empty, non existent dir.

What changes are included in this PR?

  • Fix the path
  • Prevent the upload from failing silently when no wheels are found

Are these changes tested?

crossbow

Are there any user-facing changes?

no

@github-actions
Copy link

⚠️ GitHub issue #45155 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Jan 10, 2025
@assignUser
Copy link
Member Author

assignUser commented Jan 10, 2025 •
edited
Loading

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions
Copy link

Revision: 423dce68311d05adb60fff48f51ffad1c78f5434

Submitted crossbow builds: ursacomputing/crossbow @ actions-7901efe159

Task Status
wheel-windows-cp313-cp313-amd64 GitHub Actions

@assignUser
Copy link
Member Author

The check works: https://github.com/ursacomputing/crossbow/actions/runs/12715608580/job/35448176512#step:17:25

@assignUser
Copy link
Member Author

assignUser commented Jan 10, 2025 •
edited
Loading

@github-actions crossbow submit wheel-windows-*

This will upload the wheels, I'll remove the gate afterwards and merge so the nightly jobs work again.

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
kou
kou reviewed Jan 11, 2025
View reviewed changes
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jan 11, 2025
kou
kou reviewed Jan 11, 2025
View reviewed changes
@assignUser @kou
actually fix the path
7f3901b 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 11, 2025
@assignUser
Copy link
Member Author

assignUser commented Jan 11, 2025 •
edited
Loading

@github-actions crossbow submit wheel-windows-*

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions
Copy link

Revision: a4047f4

Submitted crossbow builds: ursacomputing/crossbow @ actions-b7bf5250f6

Task Status
wheel-windows-cp310-cp310-amd64 GitHub Actions
wheel-windows-cp311-cp311-amd64 GitHub Actions
wheel-windows-cp312-cp312-amd64 GitHub Actions
wheel-windows-cp313-cp313-amd64 GitHub Actions
wheel-windows-cp313-cp313t-amd64 GitHub Actions
wheel-windows-cp39-cp39-amd64 GitHub Actions

@assignUser assignUser requested a review from kou January 11, 2025 22:40
kou
kou approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

dev/tasks/macros.jinja
Comment on lines +192 to +193
echo "No wheel files found!"
exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use 2-space indent like others?

Suggested change
echo "No wheel files found!"
exit 1
echo "No wheel files found!"
exit 1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jan 12, 2025
raulcd
raulcd approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I've learnt about compgen today

@assignUser assignUser merged commit 0d61cfd into apache:main Jan 13, 2025
9 checks passed
@assignUser assignUser removed the awaiting merge Awaiting merge label Jan 13, 2025
@assignUser assignUser mentioned this pull request Jan 13, 2025
Closed
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0d61cfd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@raulcd raulcd raulcd approved these changes

@jonkeane jonkeane Awaiting requested review from jonkeane jonkeane is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@assignUser @kou @raulcd