GH-44360: [C#] Fix Flight DoExchange incompatibility with C++ implementation #44424
+430
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreeve
requested review from
assignUser,
jonkeane,
kou,
raulcd,
CurtHagenlocher and
lidavidm
as code owners
github-actions
bot
added
Component: C++
Component: C#
Component: FlightRPC
awaiting review
adamreeve
commented
Oct 15, 2024
| "do_exchange:echo", | ||
| description=("Test the do_exchange method by " | ||
| "echoing data back to the client."), | ||
| skip_testers={"Go", "Java", "JS", "Rust"}, |
There was a problem hiding this comment.
I have a Java implementation working too but think that should be a separate PR.
github-actions
bot
added
awaiting committer review
|
I've also updated the status doc which had said DoExchange and Handshake were unsupported. It looks like Handshake support was added as part of #36079. |
lidavidm
approved these changes
Oct 15, 2024
github-actions
bot
added
awaiting merge
CurtHagenlocher
approved these changes
Oct 16, 2024
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit da5a295. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #44360
What changes are included in this PR?
do_exchangebetween C++/Python and .NET.Are these changes tested?
Are there any user-facing changes?
No