Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36078: [C#] Flight SQL implementation for C# #36079

Merged
merged 14 commits into from
Aug 28, 2023

Conversation

jeremyosterhoudt
Copy link
Contributor

@jeremyosterhoudt jeremyosterhoudt commented Jun 14, 2023

Flight SQL implementation for C# that is compatible with the C++ and Java implementations.

Closes issue #36078

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@jeremyosterhoudt jeremyosterhoudt changed the title [C#] Flight SQL implementation for C# GH-36078: [C#] Flight SQL implementation for C# Jun 14, 2023
@github-actions
Copy link

⚠️ GitHub issue #36078 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this. I don't know a whole lot about flight SQL so I'm probably not going to detect a missing message or command. I went through this and made a few questions I hope you can help me with.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jul 17, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jul 18, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 2, 2023
@jeremyosterhoudt
Copy link
Contributor Author

@westonpace bump just in case you may not have seen the request for re-review

@westonpace
Copy link
Member

Thanks for the ping. For some reason I thought this had already merged. Thanks for addressing the feedback, I think this is good to go now. I've merged with main and will let CI run one more time.

@westonpace westonpace merged commit be5ab86 into apache:main Aug 28, 2023
8 checks passed
@westonpace westonpace removed the awaiting change review Awaiting change review label Aug 28, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit be5ab86.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
Flight SQL implementation for C# that is compatible with the C++ and Java implementations.

Closes issue apache#36078 
* Closes: apache#36078

Lead-authored-by: Jeremy Osterhoudt <jeremy.osterhoudt@ge.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#][FlightSQL] Implement Flight SQL for C#
2 participants