Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-4642: [R] change f to file in read_parquet_file() #3703

Closed
wants to merge 1 commit into from
Closed

ARROW-4642: [R] change f to file in read_parquet_file() #3703

wants to merge 1 commit into from

Conversation

bgreenwell
Copy link
Contributor

Otherwise you get the following error:

Error in read_parquet_file(f) : object 'f' not found

@kou
Copy link
Member

kou commented Feb 20, 2019

Could you open an issue on JIRA:https://issues.apache.org/jira/browse/ARROW and prepend "ARROW-XXX: [R] " to the title?

See also https://cwiki.apache.org/confluence/display/ARROW/Contributing+to+Apache+Arrow

@kszucs
Copy link
Member

kszucs commented Feb 21, 2019

@bgreenwell could You please add a simple test case for it?

@kou kou changed the title 🐛 change f to file in read_parquet_file() ARROW-4647: [R] change f to file in read_parquet_file() Feb 22, 2019
@kou kou mentioned this pull request Feb 22, 2019
Closed
wesm
wesm approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. We have no tests at all for R+Parquet so I presume that @romainfrancois will address that in due course

@wesm wesm closed this in a2e8fee Feb 25, 2019
wesm pushed a commit that referenced this pull request Feb 25, 2019
@bgreenwell @wesm
ARROW-4642: [R] change f to file in read_parquet_file()
5f13d0f 
Otherwise you get the following error:
```
Error in read_parquet_file(f) : object 'f' not found
```

Author: Brandon Greenwell <greenwell.brandon@gmail.com>

Closes #3703 from bgreenwell/patch-1 and squashes the following commits:

bda541b <Brandon Greenwell> 🐛 change f to file in read_parquet_file()
@wesm wesm changed the title ARROW-4647: [R] change f to file in read_parquet_file() ARROW-4642: [R] change f to file in read_parquet_file() Feb 25, 2019
@romainfrancois
Copy link
Contributor

Yes. parquet is next on my list, we currently don't have a write function , which I'll need to test a round trip.

This was referenced Mar 29, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesm wesm wesm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bgreenwell @kou @kszucs @romainfrancois @wesm