Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix R parquet #3366

Closed
wants to merge 1 commit into from
Closed

fix R parquet #3366

wants to merge 1 commit into from

Conversation

jeffwong-nflx
Copy link
Contributor

Hi @romainfrancois , this is a one line fix to read_parquet. We accidentally left filename as f, when it should be file

romainfrancois
romainfrancois approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@romainfrancois romainfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@wesm we can either merge this anytime, otherwise i’m soon working on another parquet pr with tests and writing

@wesm
Copy link
Member

wesm commented Jan 10, 2019

I'll wait for unit tests, if that is okay. Since we aren't able to package R yet for CRAN (still no conclusive plan based on https://lists.apache.org/thread.html/13dda66d913c099af37e29165f45453cab8952d35380c14a038acfc4@%3Cdev.arrow.apache.org%3E) for 0.12 there is no immediate urgency

@jeffwong-nflx
Copy link
Contributor Author

@romainfrancois are you already working on a write_parquet and tests for read/write? If not I can contribute so that this is mergeable

@kou
Copy link
Member

kou commented Feb 22, 2019

Did you open an issue on JIRA? Could you prepend "ARROW-XXX" like #3230?
It seems that #3703 is duplicated.

@romainfrancois
Copy link
Contributor

Hello, parquet is next on my agenda, but things always find a way to skip the line, e.g. holidays this week

@wesm
Copy link
Member

wesm commented Feb 28, 2019

I had merged the other fix, so closing this

@wesm wesm closed this Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainfrancois romainfrancois romainfrancois approved these changes

Assignees
No one assigned
Labels
Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffwong-nflx @wesm @kou @romainfrancois