Skip to content

Conversation

@nealrichardson
Copy link
Member

Also fixes some test warnings. Still to-do: address the failing (now skipped) string reverse functions added in #10589.

@github-actions
Copy link

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor nit about testing the warning

@thisisnic
Copy link
Member

Looks like a good way of solving the problem of the wrong warnings being given, and adding the warning text in the call to the test function instead of wrapping it in expect_warning makes for more readable tests.

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I suggested an edit to the docs to make them a little bit easier to read the special cases.

Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants