Skip to content

ARROW-12869: [R] Bindings for utf8_reverse and ascii_reverse #10589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

ARROW-12869: [R] Bindings for utf8_reverse and ascii_reverse #10589

wants to merge 6 commits into from

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Jun 24, 2021 •
edited by ianmcook
Loading

This adds tests of the ascii_reverse kernel and a binding and tests for the stri_reverse function which calls the utf8_reverse kernel

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-12869

@ianmcook
Copy link
Member

Maybe map the function stri_reverse (from stringi) to it?

ianmcook
ianmcook reviewed Jun 24, 2021
View reviewed changes
@ianmcook
Copy link
Member

Looks good, thanks Nic! Could you please update the cheeky description to reflect that this PR is not quite so pointless now that it contains an actual function mapping? Then I'll merge.

@thisisnic
Copy link
Member Author

Looks good, thanks Nic! Could you please update the cheeky description to reflect that this PR is not quite so pointless now that it contains an actual function mapping? Then I'll merge.

Good point...done!

@thisisnic
Copy link
Member Author

@ianmcook It's still not happy with that stringi function; what do you reckon is best to do?

@ianmcook
Copy link
Member

@ianmcook It's still not happy with that stringi function; what do you reckon is best to do?

Dang, ok, this has been a learning experience for me! 🤦‍♂️

I'm of the opinion that it's bad to add new suggests unless there's a really good reason to do so. But maybe that's overzealous. Probably best to roll back to bcc7295 and let stringi be in the suggests.

@thisisnic thisisnic force-pushed the ARROW-12869_str_reverse branch from 11065d5 to bcc7295 Compare June 24, 2021 14:11
ianmcook
ianmcook reviewed Jun 24, 2021
View reviewed changes
ianmcook
ianmcook reviewed Jun 24, 2021
View reviewed changes
@ianmcook ianmcook closed this in c4a20e9 Jun 24, 2021
@nealrichardson nealrichardson mentioned this pull request Jul 12, 2021
Closed
nealrichardson added a commit that referenced this pull request Jul 13, 2021
@nealrichardson
ARROW-12994: [R] Fix tests that assume UTC local tz
75a6475 
Also fixes some test warnings. Still to-do: address the failing (now skipped) string reverse functions added in #10589.

Closes #10706 from nealrichardson/arrow-12994

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
@asfimport asfimport mentioned this pull request Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianmcook ianmcook ianmcook left review comments

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thisisnic @ianmcook