Fix Clippy in CI for Rust 1.87 release #7514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
alamb
commented
May 15, 2025
| @@ -485,6 +485,7 @@ impl<K: ArrowDictionaryKeyType> DictionaryArray<K> { | |||
|
|
|||
| /// Returns `PrimitiveDictionaryBuilder` of this dictionary array for mutating | |||
| /// its keys and values if the underlying data buffer is not shared by others. | |||
| #[allow(clippy::result_large_err)] | |||
There was a problem hiding this comment.
this API purposely returns self on failure, which is large. Thus I ignored the clippy lint
alamb
commented
May 15, 2025
| @@ -112,6 +112,7 @@ static TABLES: Lazy<Vec<&'static str>> = Lazy::new(|| vec!["flight_sql.example.t | |||
| pub struct FlightSqlServiceImpl {} | |||
|
|
|||
| impl FlightSqlServiceImpl { | |||
| #[allow(clippy::result_large_err)] | |||
There was a problem hiding this comment.
this is an example and follows the example of tonic status
| @@ -76,7 +76,7 @@ pub async fn run_scenario(host: &str, port: u16) -> Result { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[allow(clippy::unnecessary_wraps)] | |||
| #[allow(clippy::result_large_err)] | |||
There was a problem hiding this comment.
seems the previous lint has been fixed but now I need to add a new allow
parquet/src/compression.rs
Outdated
| @@ -702,24 +702,21 @@ mod lz4_hadoop_codec { | |||
| input_len -= PREFIX_LEN; | |||
|
|
|||
| if input_len < expected_compressed_size as usize { | |||
| return Err(io::Error::new( | |||
| io::ErrorKind::Other, | |||
| return Err(io::Error::other( | |||
There was a problem hiding this comment.
clippy told me to do this
This was referenced May 16, 2025
|
Thank you for the review @crepererum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Rust 1.87 was released today https://releases.rs/docs/1.87.0/ and with it some new clippy lints
Some new clippy failures now happen on main as a result, for example https://github.com/apache/arrow-rs/actions/runs/15054299671/job/42316440085
What changes are included in this PR?
cargo updateand fix all clippy errorsAre there any user-facing changes?
No, this is all internal changes