Fix record API support for reading INT32 encoded TIME_MILLIS #7511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @njaremko -- this looks good to me . I have started the CI I also want to double check the arrow reader supports this conversion too. |
|
I believe the CI failures are due to the new release of Rust. Once we merge #7514 they should pass on this PR |
alamb
approved these changes
May 16, 2025
| @@ -671,6 +671,7 @@ impl Field { | |||
| ConvertedType::UINT_16 => Field::UShort(value as u16), | |||
| ConvertedType::UINT_32 => Field::UInt(value as u32), | |||
| ConvertedType::DATE => Field::Date(value), | |||
| ConvertedType::TIME_MILLIS => Field::TimestampMillis(value as i64), | |||
There was a problem hiding this comment.
The arrow reader also does this translation:
…t32-timestamp-records
|
Thanks again @njaremko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Snowflake exports with this encoding, so (I'm assuming) it's a valid representation, and we should support parsing it.
What changes are included in this PR?
The ability to parse INT32 encoded TIME_MILLIS in the record API, and a test.
Are there any user-facing changes?
No