Update to chrono 0.4.34 #5385
Merged
Update to chrono 0.4.34 #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Feb 11, 2024
| @@ -115,6 +115,8 @@ jobs: | |||
| uses: ./.github/actions/setup-builder | |||
| - name: Install cargo-msrv | |||
| run: cargo install cargo-msrv | |||
| - name: Downgrade arrow dependencies | |||
| run: cargo update -p ahash --precise 0.8.7 | |||
There was a problem hiding this comment.
ahash 0.8.8 bumped the MSRV to 1.72
alamb
reviewed
Feb 11, 2024
| @@ -1013,9 +1013,9 @@ mod tests { | |||
| assert_eq!(pretty[2], "0 days 0 hours 0 mins 0.000001000 secs"); | |||
| assert_eq!(iso[3], "-PT0.000001S"); | |||
| assert_eq!(pretty[3], "0 days 0 hours 0 mins -0.000001000 secs"); | |||
| assert_eq!(iso[4], "P45DT50554.123456789S"); | |||
| assert_eq!(iso[4], "PT3938554.123456789S"); | |||
There was a problem hiding this comment.
why did these values change? They look closer to the pretty version with the former formatting (like 45 days)
Is this something we need to change in pretty print?
There was a problem hiding this comment.
As per the PR description - chronotope/chrono#1328 changed the formatting to be more "correct". As the pretty version is focused on human readability, not precision, I am not sure it needs to be updated
| @@ -1192,7 +1192,7 @@ mod tests { | |||
|
|
|||
| assert_json_eq( | |||
| &buf, | |||
| r#"{"duration_sec":"PT120S","duration_msec":"PT0.120S","duration_usec":"PT0.000120S","duration_nsec":"PT0.000000120S","name":"a"} | |||
| r#"{"duration_sec":"PT120S","duration_msec":"PT0.12S","duration_usec":"PT0.00012S","duration_nsec":"PT0.00000012S","name":"a"} | |||
alamb
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
chronotope/chrono#1328 changed chrono to no longer convert durations to a number of days when printing in the ISO compatible format.
What changes are included in this PR?
Are there any user-facing changes?
Technically maybe, although it wasn't a breaking chrono release so I'm not sure...