Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: utility functions for creating FixedSizeList and LargeList dtypes #5373

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

universalmind303
Copy link
Contributor

Which issue does this PR close?

Closes #5372

What changes are included in this PR?

adds a few new helper functions to DataType and Field for initializing FixedSizeList and LargeList

Are there any user-facing changes?

just the aforementioned helper functions.

@universalmind303 universalmind303 changed the title feat: utility functions for creating fsl dtype feat: utility functions for creating FixedSizeList and LargeList dtypes Feb 7, 2024
Copy link
Member

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great to me. I've been wanting these methods myself.

@wjones127 wjones127 added the arrow Changes to the arrow crate label Feb 15, 2024
@wjones127
Copy link
Member

The failed CI job is fixed on main here. I validated if I merge master into this branch the check will pass.

@wjones127 wjones127 merged commit a88d70d into apache:master Feb 15, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better ergonomics for FixedSizeList and LargeList
2 participants