Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take kernel support for StringViewArray and BinaryViewArray #5511

Closed
Tracked by #5374
alamb opened this issue Mar 14, 2024 · 2 comments · Fixed by #5602
Closed
Tracked by #5374

take kernel support for StringViewArray and BinaryViewArray #5511

alamb opened this issue Mar 14, 2024 · 2 comments · Fixed by #5602
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Mar 14, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is part of the larger project to implement StringViewArray -- see #5374

In #5481 we added support for StringViewArray and ByteViewArray.

This ticket tracks supporting StringViewArray and ByteViewArray in the take kernel: https://docs.rs/arrow/latest/arrow/compute/kernels/take/index.html

Describe the solution you'd like

  1. Support StringViewArray and ByteViewArray the take kernel
  2. Add tests

Notes:

  1. you should be able to follow the model of DictionaryArray as the idea is similar
  2. Filtering should not copy any strings, it should just manipulate the fixed size views

Describe alternatives you've considered

Additional context

@RinChanNOWWW
Copy link
Contributor

I want to try this.

@tustvold tustvold added the arrow Changes to the arrow crate label Apr 17, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #5602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants