Implement take kernel for byte view array.
#5602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RinChanNOWWW
commented
Apr 8, 2024
tustvold
approved these changes
Apr 9, 2024
| @@ -779,6 +779,34 @@ pub trait AsArray: private::Sealed { | |||
| self.as_bytes_opt().expect("binary array") | |||
| } | |||
|
|
|||
| /// Downcast this to a [`StringViewArray`] returning `None` if not possible | |||
| fn as_string_view(&self) -> &StringViewArray { | |||
There was a problem hiding this comment.
This is not a breaking change as the trait is sealed
Comment on lines
+451
to
+452
| let new_views = take_native(array.views(), indices); | ||
| let new_nulls = take_nulls(array.nulls(), indices); |
There was a problem hiding this comment.
It's beautiful how these traits just magically work
|
I took the liberty of switching to use ArrayData equality and renaming the AsArray method to byte_view. Whilst |
|
Thank you @RinChanNOWWW and @tustvold FYI @ariesdevil and @XiangpengHao -- its happening! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5511.
Rationale for this change
Necessary feature.
What changes are included in this PR?
takekernel forStringViewArrayandByteViewArray.Are there any user-facing changes?
No.