Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set the health check log level by gin to debug #1580

Merged
merged 2 commits into from
Mar 3, 2023
Merged

fix: set the health check log level by gin to debug #1580

merged 2 commits into from
Mar 3, 2023

Conversation

aynp
Copy link
Contributor

@aynp aynp commented Jan 3, 2023 •
edited
Loading

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

close: #1546

  • Modify log level (this can meet your basic needs)
  • Replace the logger of this part with the same logger as other part

gin_logger now does not require passing of DefaultLogger to it. It uses the same logger as other parts.

aynp and others added 2 commits January 2, 2023 16:36
@aynp aynp marked this pull request as ready for review January 4, 2023 07:33
@tao12345666333 tao12345666333 added this to the v1.7.0 milestone Jan 29, 2023
@tao12345666333 tao12345666333 merged commit 51d0ecd into apache:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingsamuel lingsamuel lingsamuel approved these changes

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@AlinsRan AlinsRan Awaiting requested review from AlinsRan

Assignees
No one assigned
Labels
area/controller
Projects
Apache APISIX Ingress controller
Status: Done
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

fix: set the health check log level by gin to debug
3 participants
@aynp @tao12345666333 @lingsamuel