Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the health check log level by gin to debug #1546

Closed
huweihuang opened this issue Dec 20, 2022 · 2 comments · Fixed by #1580
Closed

fix: set the health check log level by gin to debug #1546

huweihuang opened this issue Dec 20, 2022 · 2 comments · Fixed by #1580
Assignees
Labels
area/controller good first issue Good for newcomers help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@huweihuang
Copy link

Issue description

the health check log level is the info level and affected the business log.

info	gin@v1.8.1/context.go:173	path: /healthz

Environment

  • your apisix-ingress-controller version (output of apisix-ingress-controller version --long):
  • your Kubernetes cluster version (output of kubectl version):
  • if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a):

Minimal test code / Steps to reproduce

kubectl logs -f ingress-controller pod

Actual result

debug	gin@v1.8.1/context.go:173	path: /healthz

Error log

info	gin@v1.8.1/context.go:173	path: /healthz

Expected result

No response

@tao12345666333 tao12345666333 added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 26, 2022
@tao12345666333
Copy link
Member

thanks for your report.

I think the following two steps are required:

  • modify log level (this can meet your basic needs)
  • Replace the logger of this part with the same logger as other parts

@tao12345666333 tao12345666333 added area/controller triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Dec 26, 2022
@aynp
Copy link
Contributor

aynp commented Jan 2, 2023

I can take this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller good first issue Good for newcomers help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants