Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiprocessing Connection import error on OSX #8711

Merged
merged 2 commits into from
May 4, 2020
Merged

Fix multiprocessing Connection import error on OSX #8711

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29dd019
Import Connection directly from Multiprocessing.connection.
jhtimmins May 4, 2020
38e4589
Merge branch 'master' of https://github.com/apache/airflow into impor…
jhtimmins May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions airflow/utils/dag_processing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from collections import defaultdict
from datetime import datetime, timedelta
from importlib import import_module
from multiprocessing.connection import Connection as MultiprocessingConnection
from typing import Any, Callable, Dict, KeysView, List, NamedTuple, Optional, Tuple

from setproctitle import setproctitle # pylint: disable=no-name-in-module
Expand Down Expand Up @@ -546,7 +547,7 @@ class DagFileProcessorManager(LoggingMixin): # pylint: disable=too-many-instanc
:param processor_timeout: How long to wait before timing out a DAG file processor
:type processor_timeout: timedelta
:param signal_conn: connection to communicate signal with processor agent.
:type signal_conn: multiprocessing.connection.Connection
:type signal_conn: MultiprocessingConnection
:param async_mode: whether to start the manager in async mode
:type async_mode: bool
"""
Expand All @@ -559,7 +560,7 @@ def __init__(self,
AbstractDagFileProcessorProcess
],
processor_timeout: timedelta,
signal_conn: multiprocessing.connection.Connection,
signal_conn: MultiprocessingConnection,
async_mode: bool = True):
super().__init__()
self._file_paths: List[str] = []
Expand Down