-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiprocessing Connection import error on OSX #8711
Merged
ashb
merged 2 commits into
apache:master
from
jhtimmins:import-multiprocessing-connection
May 4, 2020
Merged
Fix multiprocessing Connection import error on OSX #8711
ashb
merged 2 commits into
apache:master
from
jhtimmins:import-multiprocessing-connection
May 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
including HA (high availability) scheduler
label
May 4, 2020
This only affects Py3.8+ right? |
ashb
approved these changes
May 4, 2020
dimberman
approved these changes
May 4, 2020
3 tasks
@ashb No, it comes up in (at least) 3.7.7 as well. |
mik-laj
approved these changes
May 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This problem also occurs on Linux.
https://github.com/apache/airflow/runs/644247542
kaxil
approved these changes
May 4, 2020
Makes me wonder, what changed !! |
Most likely was introduced in Python 3.7.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, dag_processing.py imports the
multiprocessing
library, and usesmultiprocessing.connection.Connection
to declare aConnection
type for theDagFileProcessorManager
class. This causes an import error on OS X.This happens because the
multiprocessing
package does not expose the.connection
module by default. To access this behavior, you need to callmultiprocessing.allow_connection_pickling()
first.Alternatively, instead of importing
multiprocessing
callingmultiprocessing.connection.Connection
in your code, you can import the Connection class directly:This PR makes that update.Presumably, this distinction matters bc of weird rules in Python's import code.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.