Keep sync-perm going when a Dag has bad access_control - #71798
Open
Lothnic wants to merge 1 commit into
Open
Conversation
A single Dag whose access_control references a non-existent role (or an invalid resource/action) made airflow sync-perm --include-dags abort partway through, leaving every remaining Dag without its permissions synced. Skip the misconfigured Dag and continue with the rest so one bad Dag can no longer block permission sync for all good ones.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
vincbeck
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
airflow sync-perm --include-dagsiterates every Dag and syncs itsaccess_control. A single Dag referencing a non-existent role (or an invalid resource/action) raisedFabExceptionmid-loop, aborting the whole run and leaving every remaining Dag without its permissions synced.This catches
FabExceptionper-Dag increate_dag_specific_permissions, logs the misconfigured Dag, and continues with the rest — so one bad Dag can no longer block permission sync for all the good ones. The per-Dag parse path (_sync_dag_permsincollection.py) is deliberately left untouched, so a badaccess_controlstill surfaces as that Dag's import error.closes: #71795
Was generative AI tooling used to co-author this PR?
Generated-by: an AI coding assistant following the guidelines