fix(ui): guard against null/undefined dates in Gantt chart to prevent RangeError#64031
fix(ui): guard against null/undefined dates in Gantt chart to prevent RangeError#64031pierrejeambrun merged 2 commits intoapache:mainfrom
Conversation
|
@idrisakorede This PR has been converted to draft because it does not yet meet our Pull Request quality criteria. Issues found:
What to do next:
Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack. |
|
Flaky e2e test, merging. |
Backport failed to create: v3-1-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 92255b5 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
… RangeError (apache#64031) * fix(ui): guard against null/undefined dates in Gantt chart to prevent RangeError Closes: apache#63954 * Fix strict-boolean-expressions lint error in Gantt utils (cherry picked from commit 92255b5)
|
manual backport for 3.2.0 #64489 |
Fix Grid View crash (
RangeError: Invalid time value) when viewing tasks in non-terminal states (scheduled, running) with "Show Gantt" enabled. This is a regression from 3.1.7 introduced by #61250.Root cause:
dayjs(value).toISOString()is called on null/undefined date values for tasks that haven't completed yet.Changes in
utils.ts:=== null→ falsy check (!value) to also catchundefined!tryInstance.end_datefallback so null end dates use current time instead of crashingNo test coverage or behavior changes beyond the null guard. Tasks with missing end dates now render a bar extending to "now" (consistent with running task behavior).
closes: #63954
Was generative AI tooling used to co-author this PR?