Skip to content

[v3-1-test] Fix import errors not showing on UI (#61163) #61213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vincbeck merged 1 commit into from
Jan 29, 2026
Merged

[v3-1-test] Fix import errors not showing on UI (#61163) #61213

vincbeck merged 1 commit into from
Jan 29, 2026
+71 −15

Conversation

@vatsrahul1001
Copy link
Contributor

@vatsrahul1001 vatsrahul1001 commented Jan 29, 2026

Backport of #61163

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jan 29, 2026
@vatsrahul1001 vatsrahul1001 added this to the Airflow 3.1.7 milestone Jan 29, 2026
@vatsrahul1001
Fix import errors not showing on UI (apache#61163)
1262bf0 
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs.

When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row.

This was always broken for users without "read all" permissions but was masked by the early return path.
@vatsrahul1001 vatsrahul1001 force-pushed the backport-61163-upstream branch from 79aa287 to 1262bf0 Compare January 29, 2026 16:34
@vincbeck vincbeck merged commit dd1a865 into apache:v3-1-test Jan 29, 2026
86 checks passed
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ephraimbuddy ephraimbuddy ephraimbuddy approved these changes

@vincbeck vincbeck vincbeck approved these changes

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner

@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Milestone

Airflow 3.1.7

Development

Successfully merging this pull request may close these issues.

3 participants

@vatsrahul1001 @ephraimbuddy @vincbeck