Fix permissions check in import error APIs #60801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
bugraoz93
approved these changes
Jan 19, 2026
airflow-core/src/airflow/api_fastapi/core_api/routes/public/import_error.py
Show resolved
Hide resolved
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
LGTM just one question.
airflow-core/src/airflow/api_fastapi/core_api/routes/public/import_error.py
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/routes/public/import_error.py
Show resolved
Hide resolved
dheerajturaga
approved these changes
Jan 20, 2026
vincbeck
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jan 21, 2026
1 task
vincbeck
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jan 21, 2026
vincbeck
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jan 21, 2026
vincbeck
added a commit
that referenced
this pull request
Jan 21, 2026
suii2210
pushed a commit
to suii2210/airflow
that referenced
this pull request
Jan 26, 2026
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 29, 2026
Import error stopped showing on UI after #60801 which removed the early bypass for users with access to all DAGs. When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row. This was always broken for users without "read all" permissions but was masked by the early return path.
vatsrahul1001
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 29, 2026
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs. When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row. This was always broken for users without "read all" permissions but was masked by the early return path.
vatsrahul1001
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 29, 2026
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs. When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row. This was always broken for users without "read all" permissions but was masked by the early return path.
vatsrahul1001
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 29, 2026
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs. When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row. This was always broken for users without "read all" permissions but was masked by the early return path.
vincbeck
pushed a commit
that referenced
this pull request
Jan 29, 2026
Import error stopped showing on UI after #60801 which removed the early bypass for users with access to all DAGs. When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row. This was always broken for users without "read all" permissions but was masked by the early return path.
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth_manager.is_authorized_dag(method="GET", user=user)does NOT verify whether a user has permissions to read all DAGs, but whether a user is authorized to list DAGs.We should rely on
get_authorized_dag_idsto check which DAGs a user has access to.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.