-
Notifications
You must be signed in to change notification settings - Fork 16.4k
fix(fab): Add dark theme support for FAB Security pages #60908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
airflow_ui_bug.movHere is a recording using breeze. |
eladkal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
vincbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really really nice!
|
Static checks are failing |
da7c5d8 to
166e75b
Compare
|
I have fixed the issue. The problem was that the hashes were not updated for the js changes as I was not able to run pre-commit hook locally earlier. I am able to do it now. |
|
The compile-fab-assets pre-commit hook is failing in CI due to a hash mismatch between macOS and Linux environments. Issue: ✅ All checks pass locally on macOS (see screenshot below) CI Error: Compile FAB provider assets......................................................Failed
Old hash: e73e02e0b7eafdb1a6d3e8d32d4077bcddf48819650d166b3c40e938ad08a9bc Ready for CI approval to verify the fix. 🙏 |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* fix(fab): Add dark theme support for FAB Security pages Fixes apache#60541
* fix(fab): Add dark theme support for FAB Security pages Fixes apache#60541

Fix dark theme not being applied to FAB Security pages (Users, Roles, etc.)
When dark theme is enabled in the main Airflow UI, the Security menu pages
displayed in light theme because they render in an iframe from the FAB provider.
Root cause:
runtime.jswas missing from the HTML template - this prevented webpackbundles from executing (webpack's
runtimeChunk: 'single'config requiresthe runtime to be loaded first)
Changes:
runtime.jstomain.htmltemplate before other webpack bundlesapplyColorScheme()function inmain.jsto read theme from localStorageand set
data-color-schemeattribute on document rootFixes #60541