Skip to content

Conversation

@Jie211
Copy link
Contributor

@Jie211 Jie211 commented Jan 21, 2026

This PR try to fixes the inconsistency between ORM model definitions and Alembic migration definitions in the FAB provider

Problem

When FAB 5 support was added , db.create_all() was introduced in create_db_from_orm().
This causes tables to be created using ORM metadata instead of migrations when initializing a fresh database.

The ORM defines different column sizes than the migration:

Column ORM Migration
ab_user.first_name String(64) String(256)
ab_user.last_name String(64) String(256)
ab_user.email String(320) String(512)

This PR

Align the ORM column definitions to match the migration definitions.

I understand there might be alternative approaches to solve this issue (like modifying create_db_from_orm() to run migrations instead of using ORM metadata), but I believe aligning the ORM with the migration is the simplest and most straightforward fix.(not sure...)


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Jie211 Jie211 requested a review from vincbeck as a code owner January 21, 2026 10:55
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 21, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vincbeck vincbeck merged commit 065e02c into apache:main Jan 21, 2026
85 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 21, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ORM and Migration have inconsistent column sizes for ab_user.first_name/last_name

2 participants