fix(fab): Align ORM column sizes with migration definitions #60869
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try to fixes the inconsistency between ORM model definitions and Alembic migration definitions in the FAB provider
Problem
When FAB 5 support was added ,
db.create_all()was introduced increate_db_from_orm().This causes tables to be created using ORM metadata instead of migrations when initializing a fresh database.
The ORM defines different column sizes than the migration:
ab_user.first_nameab_user.last_nameab_user.emailThis PR
Align the ORM column definitions to match the migration definitions.
I understand there might be alternative approaches to solve this issue (like modifying
create_db_from_orm()to run migrations instead of using ORM metadata), but I believe aligning the ORM with the migration is the simplest and most straightforward fix.(not sure...)Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.