Skip to content

Remove non-logic redundant selection and query in FAB #60807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 1 commit into from
Jan 20, 2026
Merged

Remove non-logic redundant selection and query in FAB #60807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,11 +738,6 @@ def auth_user_registration_role_jmespath(self) -> str:
def auth_remote_user_env_var(self) -> str:
return current_app.config["AUTH_REMOTE_USER_ENV_VAR"]

@property
def auth_username_ci(self):
"""Get the auth username for CI."""
return current_app.config.get("AUTH_USERNAME_CI", True)

@property
def auth_user_registration(self):
"""Will user self registration be allowed."""
Expand Down Expand Up @@ -1435,12 +1430,6 @@ def find_user(self, username=None, email=None):
"""Find user by username or email."""
if username:
try:
if self.auth_username_ci:
return self.session.scalars(
select(self.user_model).where(
func.lower(self.user_model.username) == func.lower(username)
)
).one_or_none()
return self.session.scalars(
select(self.user_model).where(
func.lower(self.user_model.username) == func.lower(username)
Expand Down