Remove non-logic redundant selection and query in FAB #60807
Merged
+0
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
approved these changes
Jan 20, 2026
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
Nice! I do not think we use it so I think it is safe to delete
jason810496
pushed a commit
to jason810496/airflow
that referenced
this pull request
Jan 22, 2026
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jan 22, 2026
suii2210
pushed a commit
to suii2210/airflow
that referenced
this pull request
Jan 26, 2026
85 tasks
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was working on some auth stuff I saw this code and stumbled over it... had been even reworked during SQLA2 adjustements but can not find in git history why the query is the same independent of the if statement in
find_user(). Also no test is relying on this so I propose to clean this up. (I would even see a risk if something is different based on a AUTH_USERNAME_CI flag.Code is like this since at least 3 years.
I propose to delete ... except if @vincbeck has an expert opinion.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.