-
Notifications
You must be signed in to change notification settings - Fork 16.4k
(feat): add HTTP request customization parameters to SnowflakeSqlApiHook
#60689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable for me but as I have no Snowflake experience I'd ask some additional pair of eyes
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py
Outdated
Show resolved
Hide resolved
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py
Outdated
Show resolved
Hide resolved
providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py
Outdated
Show resolved
Hide resolved
SnowflakeSqlApiHook
SnowflakeSqlApiHookSnowflakeSqlApiHook
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…Hook` (apache#60689) * Add http_request_kwargs, aiohttp_session_kwargs, and aiohttp_request_kwargs parameters to allow customization of HTTP requests for both sync and async operations.
…Hook` (apache#60689) * Add http_request_kwargs, aiohttp_session_kwargs, and aiohttp_request_kwargs parameters to allow customization of HTTP requests for both sync and async operations.
Summary
This PR enhances the Snowflake SQL API hook by consistently applying the http_timeout_seconds parameter to both synchronous and asynchronous HTTP requests.
Also it updates retry logic to consider asyncio.TimeoutError retryable.
Was generative AI tooling used to co-author this PR?
Details
Tests
Sync retry behavior is already extensively covered by existing tests..
So, this PR adds coverage for timeout propagation and async timeout retries.