Skip to content

Improve insert content when generate docker file #60393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jscheffl merged 1 commit into from
Jan 11, 2026
Merged

Improve insert content when generate docker file #60393

jscheffl merged 1 commit into from
Jan 11, 2026

Conversation

@tuanhm2911
Copy link
Contributor

@tuanhm2911 tuanhm2911 commented Jan 11, 2026

What

When inserting scripts into Dockerfiles, the file write function is currently called inside a loop, causing the file to be written line by line.

Proposal

Move the file write operation outside the loop so the content is written only once. This reduces unnecessary I/O operations and improves execution time.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jan 11, 2026
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 11, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

jscheffl
jscheffl approved these changes Jan 11, 2026
View reviewed changes
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jscheffl jscheffl merged commit fd90666 into apache:main Jan 11, 2026
63 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 11, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

github-actions bot pushed a commit that referenced this pull request Jan 11, 2026
@tuanhm2911
[v3-1-test] Improve insert content when generate docker file (#60393)
ae10437 
(cherry picked from commit fd90666)

Co-authored-by: Tuan Hoang Minh <9130269+tuanhm2911@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jan 11, 2026

Backport successfully created: v3-1-test

Status Branch Result
✅ v3-1-test PR Link

jscheffl pushed a commit that referenced this pull request Jan 11, 2026
@github-actions @tuanhm2911
[v3-1-test] Improve insert content when generate docker file (#60393) (…
8192ba0 
…#60397)

(cherry picked from commit fd90666)

Co-authored-by: Tuan Hoang Minh <9130269+tuanhm2911@users.noreply.github.com>
ephraimbuddy pushed a commit that referenced this pull request Jan 13, 2026
@github-actions @tuanhm2911 @ephraimbuddy
[v3-1-test] Improve insert content when generate docker file (#60393) (…
588bf42 
…#60397)

(cherry picked from commit fd90666)

Co-authored-by: Tuan Hoang Minh <9130269+tuanhm2911@users.noreply.github.com>
iharsh02 pushed a commit to iharsh02/airflow that referenced this pull request Jan 13, 2026
@tuanhm2911 @iharsh02
Improve insert content when generate docker file (apache#60393)
9b05f6b
ephraimbuddy pushed a commit that referenced this pull request Jan 14, 2026
@github-actions @tuanhm2911 @ephraimbuddy
[v3-1-test] Improve insert content when generate docker file (#60393) (…
1cccaca 
…#60397)

(cherry picked from commit fd90666)

Co-authored-by: Tuan Hoang Minh <9130269+tuanhm2911@users.noreply.github.com>
ephraimbuddy pushed a commit that referenced this pull request Jan 16, 2026
@github-actions @tuanhm2911 @ephraimbuddy
[v3-1-test] Improve insert content when generate docker file (#60393) (…
5d931fb 
…#60397)

(cherry picked from commit fd90666)

Co-authored-by: Tuan Hoang Minh <9130269+tuanhm2911@users.noreply.github.com>
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Jan 22, 2026
@tuanhm2911 @jason810496
Improve insert content when generate docker file (apache#60393)
97dcc13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jscheffl jscheffl jscheffl approved these changes

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner

@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

Assignees

No one assigned

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tuanhm2911 @jscheffl