[helm] Isolate defaultUser handling in createUserJob #59767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhuantho
requested review from
dstandish,
hussein-awala,
jedcunningham and
jscheffl
as code owners
Contributor
Author
|
I cleaned the fork branch, so it affected to close pr:59715, so I created an alternative pr. |
romsharon98
approved these changes
Dec 24, 2025
2 tasks
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Dec 29, 2025
* [helm] Move defaultUser to createUserJob * [test] Fix ruff format * [test] Fix static check value of chart * remove redundant file --------- Co-authored-by: nhuan.bc <nhuan.bc@teko.vn>
|
Hi there - the default values of the latest Helm chart version (1.18) still reference defaultUser under webserver: Is that planned to change in the next version of the Apache Airflow Helm chart? I'm trying to deploy v1.18 with modified admin user credentials. Thanks so much, sorry if answer is obvious. |
Contributor
Yes, see this PR. You can wait until (pending/overduw) 1.19 release of the helm chart or pull it from main which includes this here. |
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
* [helm] Move defaultUser to createUserJob * [test] Fix ruff format * [test] Fix static check value of chart * remove redundant file --------- Co-authored-by: nhuan.bc <nhuan.bc@teko.vn>
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
* [helm] Move defaultUser to createUserJob * [test] Fix ruff format * [test] Fix static check value of chart * remove redundant file --------- Co-authored-by: nhuan.bc <nhuan.bc@teko.vn>
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
airflow userscommand (FAB CLI Commands). Therefore, I believe thatdefaultUsershould not be part of thewebserver or apiServer.createUserJobdepends on thewebserver, but thewebserverhas been replaced by theapiServer. As a result, we should movedefaultUserto theapiServer configuration.Solution:
defaultUserintocreateUserJobto isolate the functionality of createUserJob.webserver.defaultUserfrom the Helm chart and related tests.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.