Skip to content

Conversation

@nhuantho
Copy link
Contributor

What:

  • When I read #53198 and then checked the {release-name}-create-user-job, I saw that it is used only to create a user via the airflow users command (FAB CLI Commands). Therefore, I believe that defaultUser should not be part of the webserver or apiServer.
  • From my perspective, we should decouple the responsibilities of each service. Currently, createUserJob depends on the webserver, but the webserver has been replaced by the apiServer. As a result, we should move defaultUser to the apiServer configuration.

Solution:

  • Move defaultUser into createUserJob to isolate the functionality of createUserJob.
  • Remove the usage of webserver.defaultUser from the Helm chart and related tests.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Dec 22, 2025
@nhuantho nhuantho force-pushed the helm/move-defaultUser-to-createUserJob branch from 2cd3613 to 3853f76 Compare December 22, 2025 15:22
@nhuantho nhuantho force-pushed the helm/move-defaultUser-to-createUserJob branch from 348b270 to 870fd3d Compare December 22, 2025 18:02
@jscheffl
Copy link
Contributor

jscheffl commented Dec 22, 2025

Technically you are right and thanks for the contribution.

Nevertheless we have usually a semantic release mindset, so if somebody is using Helm chart 1.18.0 so far and upgrades, the user creation would be missing. In my view a backwards-compatibility is needed for people migrating so that older values are also supported. Or we need to postpone this change to a version 2.0 where we can introduce breaking changes.

@jedcunningham WDYT?

@nhuantho
Copy link
Contributor Author

nhuantho commented Dec 23, 2025

Thanks @jscheffl, I agree with you, so can you create milestones for version 2.0 (Will version 2.0 deprecate webserver) .
I think we can add some issues here (it is only my suggestion):

  • Deprecate webserver in helm chart
  • Add a tool to migrate webserver config to apiServer config 57519
  • Update parameters
    • Add overwrite section page to give the main components in helm chart and explain overview about their goals.
    • Remove webserver parameters.
    • Split parameters for each job (currently, all parameters of all jobs are in a table).
  • Update production-guide related to webserver

I am willing to contribute these issues.

@nhuantho nhuantho closed this Dec 23, 2025
@nhuantho nhuantho deleted the helm/move-defaultUser-to-createUserJob branch December 23, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants