Skip to content

Conversation

@choo121600
Copy link
Member

E2E test to verify pagination functionality on the Dags list page.

Add dags-pagination.spec.ts E2E test that verifies:

  • Pagination buttons are visible
  • Clicking next page & previous page
image

closes: #59308


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 14, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just one nit to make it easier for follow up PRs:

Can we put that into a airflow-core/src/airflow/ui/tests/e2e/specs/dags-list.spec.ts file.

Similarly to https://github.com/apache/airflow/pull/59374 so all daglist related tests are in the same file.

@vatsrahul1001
Copy link
Contributor

vatsrahul1001 commented Dec 16, 2025

Nice!

@choo121600 We noticed all of the UI e2e test skipped as additional-prod-image-tests skipped. I have fixed this in #59523 and now rebase now tests should run

@vatsrahul1001
Copy link
Contributor

LGTM

Just one nit to make it easier for follow up PRs:

Can we put that into a airflow-core/src/airflow/ui/tests/e2e/specs/dags-list.spec.ts file.

Similarly to https://github.com/apache/airflow/pull/59374 so all daglist related tests are in the same file.

Yeah agree with @pierrejeambrun all of test realted to dag list should be in a file

@vatsrahul1001
Copy link
Contributor

Now all of the UI e2e tests ran fine.
image
@choo121600 we should be good to merge after put test to file airflow-core/src/airflow/ui/tests/e2e/specs/dags-list.spec.ts

@choo121600
Copy link
Member Author

CI failure that I don’t understand why👀

@choo121600
Copy link
Member Author

I think dag-trigger.spec.ts should also be moved to dag-list.spec.ts. What do you think?

@vatsrahul1001
Copy link
Contributor

vatsrahul1001 commented Dec 17, 2025

I think dag-trigger.spec.ts should also be moved to dag-list.spec.ts. What do you think?

Yes, should be in dag-list.spec.ts. Would you like to address that in separate PR?

@vatsrahul1001
Copy link
Contributor

CI failure that I don’t understand why👀

Was due to Sphinx. Fixed after merging #59538

@choo121600
Copy link
Member Author

I think dag-trigger.spec.ts should also be moved to dag-list.spec.ts. What do you think?

Yes, should be in dag-list.spec.ts. Would you like to address that in separate PR?

Yes, once this PR is merged, I’ll move it in a separate PR ;)

@vatsrahul1001 vatsrahul1001 merged commit f6343b1 into apache:main Dec 17, 2025
74 checks passed
FoxHelms pushed a commit to FoxHelms/airflow that referenced this pull request Dec 17, 2025
Feat e2e test for Dags pagination
Lohith625 pushed a commit to Lohith625/airflow that referenced this pull request Dec 19, 2025
Feat e2e test for Dags pagination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI E2E Test || DAGS-007: Verify pagination works

3 participants