-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add support for disabling SA token automount for Scheduler #59156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for disabling SA token automount for Scheduler #59156
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
…r when using Pod launching executors (apache#59099)
0d419b6 to
1c63149
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and the extensive documentation added. Not many PRs make such a good and proper documentation alongside the functional contribution!
Two pieces are too verbose, can you adjust these? Then in my view it is okay to be merged.
…n page and created newsfragment 59156.significant.rst to properly document these changes in the changelog as suggested. (apache#59099)
…edicated service-account-token-examples.rst document for comprehensive configuration examples and use cases. (apache#59099)
…r when using Pod launching executors (apache#59099)
…n page and created newsfragment 59156.significant.rst to properly document these changes in the changelog as suggested. (apache#59099)
…edicated service-account-token-examples.rst document for comprehensive configuration examples and use cases. (apache#59099)
4ed219a to
d5f5e41
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me now! Let's make CI green and then LGTM!
|
Ups, some nit in RST formatting - can you fix? |
…t-for-scheduler' into bugfix/59099-disable-sa-automount-for-scheduler
Is there any way to make these flaky tests green? Can I retrigger them on my own somehow? |
Yes. Rebase your PR or close/reopen it - the problem was with GitHub having hiccups - so those were not flaky tests - those were tests that did not run because GitHub infrastructure had problems. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
) * Add support for manual mounting of Service Account tokens in Scheduler when using Pod launching executors (apache#59099) * fix bug in helper function for determining if executor is Pod launching (apache#59099) * Remove emojis in production guide (apache#59099) * Auto formatting by prek and some manual cleanup (apache#59099) * Removed the detailed security enhancements from the main documentation page and created newsfragment 59156.significant.rst to properly document these changes in the changelog as suggested. (apache#59099) * Reduced redundancy by removing detailed examples and linking to the dedicated service-account-token-examples.rst document for comprehensive configuration examples and use cases. (apache#59099) * Add support for manual mounting of Service Account tokens in Scheduler when using Pod launching executors (apache#59099) * fix bug in helper function for determining if executor is Pod launching (apache#59099) * Remove emojis in production guide (apache#59099) * Auto formatting by prek and some manual cleanup (apache#59099) * Removed the detailed security enhancements from the main documentation page and created newsfragment 59156.significant.rst to properly document these changes in the changelog as suggested. (apache#59099) * Reduced redundancy by removing detailed examples and linking to the dedicated service-account-token-examples.rst document for comprehensive configuration examples and use cases. (apache#59099) * Fix title underlines in SA token examples RST file. (apache#59099) * Fix spell checks and removed wrong Helm values schema spec for Worker. (apache#59099) * Minor fix in descriptions. (apache#59099) --------- Co-authored-by: Dan Osterrath <9108541+dan-osterrath@users.noreply.github.com>
This PR adds support to the Airflow Helm chart for disabling the service account token automounting into the Airflow Scheduler pods. This might be restricted by cluster policies for security reasons and best practices. When automounting is disabled and the executor is a Pod launching executor (
CeleryExecutor,CeleryKubernetesExecutor,KubernetesExecutororLocalKubernetesExecutor), the service account token is mounted manually into the Schedulers container. You can configure some token parameters like volume name, mount path, token audience and TTL. By default the service account token is still mounted automatically to keep backward compatibility. There are sensible defaults for the token parameters to keep backward compatibility.closes: #59099
related: #30722 #43464