-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add Neo4jSensor to Neo4j Provider #58549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
9718053 to
58f551c
Compare
|
As long as all CI tests pass. |
|
Hello, so I think I failed to rebase properly and it included the commits from the apache airflow main branch again in my PR commits, If this is not an issue, I will raise another PR properly, Please let me know. Thanks |
60b6803 to
63da337
Compare
|
Can you push another small commit so that the CI tests run |
63da337 to
45e1e8f
Compare
45e1e8f to
4b957dc
Compare
…her" term to the spelling_wordlist for the doc checks.
4b957dc to
f447dec
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* Added new Neo4j Sensor, Unit tests, System tests, Docs and added "Cypher" term to the spelling_wordlist for the doc checks. * Added docs path to the neo4j sensor in the provider.yaml file * tiny commit to enable CL tests
* Added new Neo4j Sensor, Unit tests, System tests, Docs and added "Cypher" term to the spelling_wordlist for the doc checks. * Added docs path to the neo4j sensor in the provider.yaml file * tiny commit to enable CL tests
This PR adds a Neo4jSensor to the Neo4j Provider.
It functions similarly to existing SQL-based sensor of polling the neo4j graph database (here with Cypher) for a condition to be met.
The Neo4j query run is called from the
Neo4jHookclass to connect with a Neo4j graph database instead ofDbApiHookwhich lead to the necessity for adding a separate Sensor to Neo4j.Airflow Components Added
Neo4jSensor- Polls (Executes a Cypher query in Neo4j) until the returned value satisfies a condition.Tests
Unit Tests- Added and tested within breeze using pytest for possible combinations and functionalitiesStatic Checks
Prek- Prek hooks were run within breeze for my commits and passed static checks.Documentation
Neo4jSensor Documentation- added to theproviders/neo4j/docs/neo4j/sensors/neo4j.rstSpelling Word List
Cypher- Term was added to thedocs/spelling_wordlist.txtfor the documentation generation.