Skip to content

Conversation

@themadcoder23
Copy link
Contributor

This PR updates the default docstring for the on_finish_action parameter in the GKE start function to correctly reflect its intended behavior. The previous wording was misleading/inaccurate, so this change improves clarity for users and developers reading the function documentation.

What is changed:
Updated docstring to describe correct expected action/behavior

Why this change is needed:
The existing docstring could lead to confusion regarding the purpose and default behavior of on_finish_action

No functional code changes, only documentation clarity improvement

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Nov 15, 2025
@potiuk potiuk merged commit c991c13 into apache:main Nov 16, 2025
84 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 16, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants