-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Adding gcp_conn_id to template_fields for GCS Operators
#58298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
jroachgolf84
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a committer, so my review holds no weight. But this looks good to me!
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
PR to add gcp_conn_id to the template_fields for GCS* operators. I validated that gcp_conn_id is parameter for each of these operators before adding it to template_fields. GCSDeleteBucketOperator and GCSSynchronizeBucketsOperator already have gcp_conn_id as template field.
According to previous issue #58236, tests are not required for this.
closes: #58296
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.